cmd/update-report: use better wording when appropriate. #13375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Jun 3, 2022
Bo98
approved these changes
Jun 3, 2022
MikeMcQuaid
changed the title
Bo98
reviewed
Jun 3, 2022
Bo98
reviewed
Jun 3, 2022
From reading https://github.com/orgs/Homebrew/discussions/3328: I initially thought we should just change "Updated" to "Modified" when appropriate. After conversation with Bo98, though, I thought more and saw that we're already checking for outdated formulae here so, rather than ever traverse through the formula history, look at the outdated formula and list them unless we've set `HOMEBREW_UPDATE_REPORT_ALL_FORMULAE` in which case we show the modifications. While we're here, also do a bit of reformatting and renaming to better clarify intent.
|
FYI @boblail hope you're happy with the various defaults and options now. If not: shout and we'll consider tweaking further. Although I didn't adopt your changes, thank you for asking the questions that motivated me into improving |
|
@MikeMcQuaid, sorry, I was AFK while moving! 👍 These changes work for me! |
2 tasks
|
@boblail Hope the move went well, glad you're OK with these changes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From reading https://github.com/orgs/Homebrew/discussions/3328: I
initially thought we should just change "Updated" to "Modified" when
appropriate. After conversation with Bo98, though, I thought more and
saw that we're already checking for outdated formulae here so, rather
than ever traverse through the formula history, look at the outdated
formula and list them unless we've set
HOMEBREW_UPDATE_REPORT_ALL_FORMULAEin which case we show themodifications.
While we're here, also do a bit of reformatting and renaming to better
clarify intent.